Code review behavior

Follow

Ryan Dillinger

• July 09, 2020 15:30
• Edited

The docs concerning code reviews and the behavior seen are not the same. An owner or manager is able to approve any pending draft (including their own draft).

The docs contradict that: "A team owner or manager can comment on drafts but may not approve them, unless she is also assigned to review a specific draft."

Members can only approve drafts assigned to them (no contradiction there).

I somewhat prefer this behavior, such that a draft isn't waiting on one specific person to be approved but rather any manager/owner/assigned-member.

I suggest correcting the behavior that a manager or owner can approve their own snippet (they should not).

Perhaps, in the future, approval privileges can be a separate policy that can be set for each member/manager. I would prefer that only managers (as a group) can approve snippets.

It's a little thing, I'm very happy with my experience. Keep up the good work!

0

• Official comment

  

  Rui Jiang

  • July 09, 2020 16:20

  Thanks for the feedback Ryan. We just got this feedback from another team and will be changing the docs to match the experience.

  Comment actions Permalink

Please sign in to leave a comment.